cloud-fan commented on a change in pull request #27197: [SPARK-30507][SQL]
TableCalalog reserved properties shoudn't be changed via options or tblpropeties
URL: https://github.com/apache/spark/pull/27197#discussion_r367220655
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -894,6 +895,87 @@ class DataSourceV2SQLSuite
}
}
+ test("create/replace/alter table - reserved properties") {
+ import TableCatalog._
+ withSQLConf((SQLConf.LEGACY_PROPERTY_NON_RESERVED.key, "false")) {
+ RESERVED_PROPERTIES.asScala.filterNot(_ == PROP_COMMENT).foreach { key =>
Review comment:
shall we just remove PROP_COMMENT from RESERVED_PROPERTIES?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
