fuwhu commented on a change in pull request #27213: [SPARK-30516][SQL]
statistic estimation of FileScan should take partitionFilters and partition
number into account
URL: https://github.com/apache/spark/pull/27213#discussion_r367294188
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileIndex.scala
##########
@@ -51,12 +51,8 @@ trait FileIndex {
* files where these predicates are guaranteed to
evaluate to `true`.
* Thus, these filters will not need to be evaluated
again on the
* returned data.
- * @param dataFilters Filters that can be applied on non-partitioned
columns. The implementation
- * does not need to guarantee these filters are applied,
i.e. the execution
- * engine will ensure these filters are still applied on
the returned files.
*/
- def listFiles(
- partitionFilters: Seq[Expression], dataFilters: Seq[Expression]):
Seq[PartitionDirectory]
+ def listPartitionData(partitionFilters: Seq[Expression]):
Seq[PartitionDirectory]
Review comment:
Since dataFilters is not used in all sub classes of FileIndex, so just
remove the dataFilters parameter here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
