zero323 commented on issue #26247: [SPARK-29566][ML] Imputer should support single-column input/output URL: https://github.com/apache/spark/pull/26247#issuecomment-575118338 Thanks for the update @huaxingao, though I still think we should have some clear guidelines where such setters should be placed. As @viirya pointed out, `Models` with direct constructors are one place. But at least having `inputCol` setter in a fitted `Model` seems a bit like a piece dead code.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
