javierivanov commented on issue #26937: [SPARK-30295][SQL] Replacing java code 
with Scala implementations in the Spark-sql cli
URL: https://github.com/apache/spark/pull/26937#issuecomment-575275800
 
 
   > Is the TL;DR here that you are inlining some Hive code so as to not depend 
on it? while I can see the value of reducing dependencies, does this much help 
much?
   
   @srowen By removing hive dependencies where it is not needed, it is a step 
forward to reduce the footprint of the code and to maybe have a future version 
of the thrift module without Hive deps. at all. It also adds maintainability 
since Java collections were replaced with scala ones and some procedures were 
divided to simplify the reading. Also, as a side effect fixes SPARK-30049. 
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to