dongjoon-hyun opened a new pull request #27242: [SPARK-30534][INFRA] Use mvn in 
`dev/scalastyle`
URL: https://github.com/apache/spark/pull/27242
 
 
   ### What changes were proposed in this pull request?
   
   This PR aims to use `mvn` instead of `sbt` in `dev/scalastyle` to recover 
GitHub Action.
   
   ### Why are the changes needed?
   
   As of now, Apache Spark sbt build is broken by the Maven Central repository 
policy.
   
https://stackoverflow.com/questions/59764749/requests-to-http-repo1-maven-org-maven2-return-a-501-https-required-status-an
   
   > Effective January 15, 2020, The Central Maven Repository no longer 
supports insecure
   > communication over plain HTTP and requires that all requests to the 
repository are 
   > encrypted over HTTPS.
   
   We can reproduce this locally by the following.
   ```
   $ rm -rf ~/.m2/repository/org/apache/apache/18/
   $ build/sbt clean
   ```
   
   And, in GitHub Action, `lint-scala` is the only one which is using `sbt`.
   
   ### Does this PR introduce any user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   First of all, GitHub Action should be recovered.
   
   Also, manually, do the following.
   
   **Without Scalastyle violation**
   ```
   $ dev/scalastyle
   OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=384m; support 
was removed in 8.0
   Using `mvn` from path: /usr/local/bin/mvn
   Scalastyle checks passed.
   ```
   
   **With Scalastyle violation**
   ```
   $ dev/scalastyle
   OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=384m; support 
was removed in 8.0
   Using `mvn` from path: /usr/local/bin/mvn
   Scalastyle checks failed at following occurrences:
   error 
file=/Users/dongjoon/PRS/SPARK-HTTP-501/core/src/main/scala/org/apache/spark/SparkConf.scala
 message=There should be no empty line separating imports in the same group. 
line=22 column=0
   error 
file=/Users/dongjoon/PRS/SPARK-HTTP-501/core/src/main/scala/org/apache/spark/SparkConf.scala
 message=There should be no empty line separating imports in the same group. 
line=35 column=0
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to