tgravescs commented on a change in pull request #27242: [SPARK-30534][INFRA]
Use mvn in `dev/scalastyle`
URL: https://github.com/apache/spark/pull/27242#discussion_r367702578
##########
File path: pom.xml
##########
@@ -2762,8 +2762,10 @@
<failOnViolation>true</failOnViolation>
<includeTestSourceDirectory>false</includeTestSourceDirectory>
<failOnWarning>false</failOnWarning>
- <sourceDirectory>${basedir}/src/main/scala</sourceDirectory>
- <testSourceDirectory>${basedir}/src/test/scala</testSourceDirectory>
+ <sourceDirectories>${basedir}/src/main/scala
+ <dir>${basedir}/src/main/scala</dir>
+ <dir>${basedir}/src/test/scala</dir>
Review comment:
why did we add the test directory in here? We have
includeTestSourceDirectory=false for some reason above. if we just turn that
on do things work or does it cause some other problems?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
