imback82 commented on a change in pull request #27243: [SPARK-30535][SQL]
Migrate ALTER TABLE commands to the new framework
URL: https://github.com/apache/spark/pull/27243#discussion_r367756809
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2916,14 +2916,14 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
* }}}
*/
override def visitAddTableColumns(ctx: AddTableColumnsContext): LogicalPlan
= withOrigin(ctx) {
- AlterTableAddColumnsStatement(
- visitMultipartIdentifier(ctx.multipartIdentifier),
+ AlterTableAddColumns(
+ UnresolvedTable(visitMultipartIdentifier(ctx.multipartIdentifier)),
Review comment:
I will be making a change to use `UnresolvedTableOrView` so that we can keep
the existing error message like `Cannot alter a view with ALTER TABLE. Please
use ALTER VIEW instead`. If not, we will just see `v1 is a view not a table`.
@cloud-fan, sounds right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
