dongjoon-hyun commented on a change in pull request #27233: [SPARK-29701][SQL] Correct behaviours of group analytical queries when empty input given URL: https://github.com/apache/spark/pull/27233#discussion_r367761927
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/OptimizeMetadataOnlyQuerySuite.scala ########## @@ -117,7 +117,8 @@ class OptimizeMetadataOnlyQuerySuite extends QueryTest with SharedSparkSession { testNotMetadataOnly( "Don't optimize metadata only query for GroupingSet/Union operator", - "select partcol1, max(partcol2) from srcpart where partcol1 = 0 group by rollup (partcol1)", + "select partcol1, max(partcol2) from srcpart where partcol1 = 0 " + + "group by grouping sets (partcol1)", Review comment: Could you add that information into the PR description in order to make it as a commit log? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org