huaxingao commented on issue #27241: [SPARK-30533][ML][PYSPARK] Add classes to represent Java Regressors and RegressionModels URL: https://github.com/apache/spark/pull/27241#issuecomment-575470546 I think on scala side, it makes more sense to make all Regression classes extend Regressor, because the Regressor class is already there and some of the Regression classes already implement Regressor, so it's better to make all Regression classes follow the same standard. But I am not so sure about python side: the Regressor class is basically empty and I am not sure if we should add another layer of abstraction, so I chose not to add Regressor/Regressor class on python side when I did https://github.com/apache/spark/pull/27168. But I know you can argue that we need change python too to keep the parity between scala and python. I am OK either way.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
