sandeep-katta commented on a change in pull request #27021: [SPARK-30362][Core]
Update InputMetrics in DataSourceRDD
URL: https://github.com/apache/spark/pull/27021#discussion_r367780432
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala
##########
@@ -56,6 +58,15 @@ class DataSourceRDD(
context.addTaskCompletionListener[Unit](_ => reader.close())
val iter = new Iterator[Any] {
private[this] var valuePrepared = false
+ private val inputMetrics = context.taskMetrics().inputMetrics
+ private val existingBytesRead = inputMetrics.bytesRead
Review comment:
yes it's true for DS V1 also. Shall we have some marker trait which says
Input Size metrics is supported. For e.g. FilePartitionReaderFactory supports
Input Size metrics. So that we can collect input size metrics only if it
supports .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
