yaooqinn commented on a change in pull request #27249: [SPARK-30019][SQL] Add
ALTER TABLE SET OWNER syntax
URL: https://github.com/apache/spark/pull/27249#discussion_r367789379
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
##########
@@ -227,13 +228,14 @@ case class AtomicReplaceTableAsSelectExec(
override protected def doExecute(): RDD[InternalRow] = {
val schema = query.schema.asNullable
+ val propertiesWithOwner = withDefaultOwnership(properties).asJava
Review comment:
Yes, they have a common parent `V2CreateTablePlan` when they are on the
logical side. We may add a method like
```scala
override def withPartitioning(rewritten: Seq[Transform]): V2CreateTablePlan
= {
this.copy(partitioning = rewritten)
}
override def withOwnership(): V2CreateTablePlan = {
this.copy(properties = this.properites ++ ownership)
}
```
but not more elegant and simpler as it is now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
