cloud-fan commented on a change in pull request #27249: [SPARK-30019][SQL] Add ALTER TABLE SET OWNER syntax URL: https://github.com/apache/spark/pull/27249#discussion_r367808944
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala ########## @@ -227,13 +228,14 @@ case class AtomicReplaceTableAsSelectExec( override protected def doExecute(): RDD[InternalRow] = { val schema = query.schema.asNullable + val propertiesWithOwner = withDefaultOwnership(properties).asJava Review comment: a logical plan may have multiple physical plans, e.g. the atomic version of CTAS. That's why I think it's better to do it at the logical phase. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org