JoshRosen commented on issue #27088: [SPARK-30413][SQL] Avoid WrappedArray roundtrip in GenericArrayData constructor URL: https://github.com/apache/spark/pull/27088#issuecomment-575708699 Let me take a look at this today / check my notes (busy week for me, hence my slow response). On Fri, Jan 17, 2020 at 8:28 AM Dongjoon Hyun <[email protected]> wrote: > *@dongjoon-hyun* approved this pull request. > > +1, LGTM. (except @maropu <https://github.com/maropu> 's comment.) > If it's difficult, we can remove the performance related stuff from the PR > description. > > cc @dbtsai <https://github.com/dbtsai> > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/27088?email_source=notifications&email_token=AAAMMPBQWZ5KQ64TCRB5C3DQ6HMBBA5CNFSM4KCKVKPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSFZ6NQ#pullrequestreview-344694582>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAMMPF4LZM2J4SFRYAEAODQ6HMBBANCNFSM4KCKVKPA> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
