tdas commented on a change in pull request #27265: [SPARK-30555][SQL] MERGE
INTO insert action should only access columns from source table
URL: https://github.com/apache/spark/pull/27265#discussion_r368148491
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala
##########
@@ -133,7 +133,10 @@ class PlanResolutionSuite extends AnalysisTest {
analyzer.ResolveRelations,
new ResolveCatalogs(catalogManager),
new ResolveSessionCatalog(catalogManager, conf, _ == Seq("v")),
- analyzer.ResolveTables)
+ analyzer.ResolveTables,
+ analyzer.ResolveReferences,
Review comment:
nit: Should these be in the same order as they are in the actual analyzer?
If so, how do we make sure that we dont break this constraint? At the very
least this should be commented as it is critical for the tests to run correctly
.. isnt it?
This is probably not relevant for this PR, but I am curious.... instead of
pulling out a few rules from the analyzer, why are we not using the Analyzer
directly (with all the rules) to parse and resolve?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
