JoshRosen commented on issue #26076: [SPARK-29419][SQL] Fix Encoder 
thread-safety bug in createDataset(Seq)
URL: https://github.com/apache/spark/pull/26076#issuecomment-575970963
 
 
   Hi @dongjoon-hyun,
   
   I spent some time prototyping a refactoring of `ExpressionEncoder` which 
separates the mutable and immutable state (in order to significantly reduce the 
cost of `.copy()`). This _is_ doable but ends up involving a lot of code 
movement and potentially some duplication (since some helper functions are in 
both the constructor and after construction). I think that's definitely the 
right long-term approach but I'll need some more time to figure out a 
minimally-invasive and clean way of making that change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to