Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/4593#issuecomment-74805610 Sorry for the late reply since I'm traveling recently. My concern is that will this cause "caching twice" in the new ML api? For example, in ml/classification/LogisticRegression.scala, the data is persisted before any transformation, and then we cache the data again after the feature transformation. Should we remove the persist in ml package and just cache it after feature transformation here?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org