cloud-fan commented on a change in pull request #27243: [SPARK-30535][SQL]
Migrate ALTER TABLE commands to the new framework
URL: https://github.com/apache/spark/pull/27243#discussion_r368387490
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -420,63 +425,71 @@ trait CheckAnalysis extends PredicateHelper {
}
case alter: AlterTable if alter.childrenResolved =>
Review comment:
nit: `case alter: AlterTable if alter.childrenResolved &&
alter.table.isInstanceOf[ResolvedTable]`
Then we don't need to change the indentation below and save a lot of code
diff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
