attilapiros commented on a change in pull request #27257: [SPARK-30540][Web UI]
HistoryServer application link is incorrect when one application having
multiple attempts
URL: https://github.com/apache/spark/pull/27257#discussion_r368573364
##########
File path: core/src/main/resources/org/apache/spark/ui/static/historypage.js
##########
@@ -140,7 +140,8 @@ $(document).ready(function() {
(attempt.hasOwnProperty("attemptId") ? attempt["attemptId"] + "/"
: "") + "logs";
Review comment:
The `{{uiroot}}/history/{{id}}/{{attemptId}}/jobs/">{{attemptId}}</a></td>`
is protected by the check `{{#hasMultipleAttempts}} ...
{{/hasMultipleAttempts}}`.
I think if there is only one attempt then the `attemptId` might be missing
and the value 1 was used for that before your change not null and empty
(because of the line `var num = app["attempts"].length;`).
So please test with that case too.
And I would like to ask you to attach some data to the PR: during testing
you can put a breakpoint (ie by placing `debugger;` into the code) before the
Mustache renders the page (it is about line 161) please copy-paste the `data`
content to a code block of the PR comment.
Could you please do that for both having multiple attempts and having only
one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
