MaxGekk commented on a change in pull request #27295: Fix src/dest type
documentation for `to_timestamp`
URL: https://github.com/apache/spark/pull/27295#discussion_r368693051
##########
File path: python/pyspark/sql/functions.py
##########
@@ -1161,7 +1161,7 @@ def to_date(col, format=None):
@since(2.2)
def to_timestamp(col, format=None):
"""Converts a :class:`Column` of :class:`pyspark.sql.types.StringType` or
- :class:`pyspark.sql.types.TimestampType` into
:class:`pyspark.sql.types.DateType`
+ :class:`pyspark.sql.types.DateType` into
:class:`pyspark.sql.types.TimestampType`
Review comment:
Cannot the function accept values of `TimestampType` as well? Internally,
the first parameter should be casted to `TimestampType`. If it is already a
timestamp, should be ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
