cloud-fan commented on a change in pull request #27300: [SPARK-30591][SQL]
Remove the nonstandard SET OWNER syntax for namespaces
URL: https://github.com/apache/spark/pull/27300#discussion_r368810236
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsNamespaces.java
##########
@@ -72,8 +67,7 @@
*
* They need specific syntax to modify
*/
- List<String> RESERVED_PROPERTIES =
- Arrays.asList(PROP_COMMENT, PROP_LOCATION, PROP_OWNER_NAME,
PROP_OWNER_TYPE);
+ List<String> RESERVED_PROPERTIES = Arrays.asList(PROP_COMMENT,
PROP_LOCATION, PROP_OWNER);
Review comment:
not related to this PR. I think which properties are reserved is an internal
thing. We should put this list in an internal class like `CatalogV2Utils`, not
in a public interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
