dongjoon-hyun commented on a change in pull request #27242:
[SPARK-30534][INFRA] Use mvn in `dev/scalastyle`
URL: https://github.com/apache/spark/pull/27242#discussion_r368855344
##########
File path: dev/scalastyle
##########
@@ -17,18 +17,10 @@
# limitations under the License.
#
-SPARK_PROFILES=${1:-"-Pmesos -Pkubernetes -Pyarn -Pspark-ganglia-lgpl
-Pkinesis-asl -Phive-thriftserver -Phive"}
+SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
-# NOTE: echo "q" is needed because SBT prompts the user for input on
encountering a build file
-# with failure (either resolution or compilation); the "q" makes SBT quit.
-ERRORS=$(echo -e "q\n" \
- | build/sbt \
- ${SPARK_PROFILES} \
- -Pdocker-integration-tests \
- -Pkubernetes-integration-tests \
- scalastyle test:scalastyle \
- | awk '{if($1~/error/)print}' \
-)
+SPARK_PROFILES=${1:-"-Pmesos -Pkubernetes -Pyarn -Pspark-ganglia-lgpl
-Pkinesis-asl -Phive-thriftserver -Phive -Pdocker-integration-tests
-Pkubernetes-integration-tests"}
+ERRORS=$($SCRIPT_DIR/../build/mvn $SPARK_PROFILES scalastyle:check | grep
"^error file")
Review comment:
I'm +1 for any suggestion if you make a PR and pass all system (including
GitHub Action). :)
BTW, did you try to checkout one of older commits than this, @HyukjinKwon ?
If it works in your environment even in that case, it sounds weird to me
because of the following.
As you can see on the mailing list, this is reported by @tgravescs and I
confirmed the situation. Then, I made this PR at that time. Also, GitHub Action
log still shows the whole situation (the **failures** before this commit and
the **successes** after this commit).
<img width="593" alt="Screen Shot 2020-01-20 at 11 48 50 PM"
src="https://user-images.githubusercontent.com/9700541/72785186-7b43ad00-3bdf-11ea-9ca4-084b7a4b8a58.png";>
For now, I don't have any clue about the difference (code side? or Maven
server side? or your environment?).
In any way, you can move forward whiling keeping our system **green**. We
had better discuss on your PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/9700541/72785186-7b43ad00-3bdf-11ea-9ca4-084b7a4b8a58.png"](https://user-images.githubusercontent.com/9700541/72785186-7b43ad00-3bdf-11ea-9ca4-084b7a4b8a58.png"){kind=link}