hvanhovell commented on a change in pull request #27267:
[WIP][SPARK-30556][SQL] Copy sparkContext.localproperties to child thread
inSubqueryExec.executionContext
URL: https://github.com/apache/spark/pull/27267#discussion_r368872512
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
##########
@@ -749,9 +749,11 @@ case class SubqueryExec(name: String, child: SparkPlan)
private lazy val relationFuture: Future[Array[InternalRow]] = {
// relationFuture is used in "doExecute". Therefore we can get the
execution id correctly here.
val executionId =
sparkContext.getLocalProperty(SQLExecution.EXECUTION_ID_KEY)
+ val localProps = Utils.cloneProperties(sparkContext.getLocalProperties)
Review comment:
Fair point. I prefer creating a narrow waist here. How about you add a
method to SQLExecution that creates the future and sets up the local properties?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
