cloud-fan commented on a change in pull request #27267: [SPARK-30556][SQL] Copy
sparkContext.localproperties to child thread inSubqueryExec.executionContext
URL: https://github.com/apache/spark/pull/27267#discussion_r369012583
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala
##########
@@ -164,4 +166,18 @@ object SQLExecution {
}
}
}
+
+ /**
+ * Wrap passed function to ensure sparkContext local properties are
forwarded to execution thread
+ */
+ def withThreadLocalCaptured[T](sparkSession: SparkSession)(body: => T)(
+ exec: ExecutionContext): Future[T] = {
+ val activeSession = sparkSession
+ val localProps =
Utils.cloneProperties(sparkSession.sparkContext.getLocalProperties)
Review comment:
do we have to clone? I know the local properties are mutable, but that was
the behavior until now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]