ajithme commented on a change in pull request #27267: [SPARK-30556][SQL] Copy
sparkContext.localproperties to child thread inSubqueryExec.executionContext
URL: https://github.com/apache/spark/pull/27267#discussion_r369023941
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala
##########
@@ -164,4 +166,18 @@ object SQLExecution {
}
}
}
+
+ /**
+ * Wrap passed function to ensure sparkContext local properties are
forwarded to execution thread
+ */
+ def withThreadLocalCaptured[T](sparkSession: SparkSession)(body: => T)(
+ exec: ExecutionContext): Future[T] = {
+ val activeSession = sparkSession
+ val localProps =
Utils.cloneProperties(sparkSession.sparkContext.getLocalProperties)
Review comment:
This is just to ensure case when the future is in waiting due to
`ExecutorService` threads being fully occupied and meanwhile any changes happen
in localProperties, that do not affect the properties which were passed on
submission. Do you feel its reasonable.?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
