dongjoon-hyun commented on a change in pull request #27293:
[SPARK-29938][SQL][FOLLOW-UP] Improve AlterTableAddPartitionCommand
URL: https://github.com/apache/spark/pull/27293#discussion_r369365437
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala
##########
@@ -137,6 +136,38 @@ object CommandUtils extends Logging {
size
}
+ def calculateLocationsSizes(
Review comment:
`calculateLocationsSizes` seems to have too many `s`; `Locations` and
`Sizes`.
Maybe, `calculateLocationSize` is clear enough because the argument `paths`
are `Seq`?
In general, in order to avoid the existing `calculateLocationSize`, having
`calculateLocationsSizes` seems not a proper naming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
