cloud-fan commented on a change in pull request #27199: [SPARK-30508][SQL] Add 
SparkSession.executeCommand API for external datasource
URL: https://github.com/apache/spark/pull/27199#discussion_r369416933
 
 

 ##########
 File path: 
sql/core/src/test/resources/META-INF/services/org.apache.spark.sql.sources.DataSourceRegister
 ##########
 @@ -2,6 +2,7 @@ org.apache.spark.sql.sources.FakeSourceOne
 org.apache.spark.sql.sources.FakeSourceTwo
 org.apache.spark.sql.sources.FakeSourceThree
 org.apache.spark.sql.sources.FakeSourceFour
+org.apache.spark.sql.sources.CommandRunnableDataSource
 
 Review comment:
   we don't need to register it as we are not testing the short name. We can 
just use the full class name when calling `spark.executeCommand`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to