cloud-fan commented on a change in pull request #27260: [SPARK-30549][SQL] Fix
the subquery shown issue in UI When enable AQE
URL: https://github.com/apache/spark/pull/27260#discussion_r369508802
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -484,10 +496,23 @@ case class AdaptiveSparkPlanExec(
* Notify the listeners of the physical plan change.
*/
private def onUpdatePlan(executionId: Long): Unit = {
-
context.session.sparkContext.listenerBus.post(SparkListenerSQLAdaptiveExecutionUpdate(
- executionId,
- SQLExecution.getQueryExecution(executionId).toString,
- SparkPlanInfo.fromSparkPlan(this)))
+ if (isSubquery) {
+ onUpdateAccumulator(collectSQLMetrics(currentPhysicalPlan), executionId)
Review comment:
let's add some comments
```
When executing subqueries, we can't update the query plan in the UI as the
UI doesn't support partial
update yet. However, the subquery may have been optimized into a different
plan and we must let the
UI know the SQL metrics of the new plan nodes, so that it can track the
valid accumulator updates later
and display SQL metrics correctly.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
