cloud-fan commented on a change in pull request #27317: [SPARK-30592][SQL]
Interval type checker for csv and json funtions
URL: https://github.com/apache/spark/pull/27317#discussion_r369511771
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala
##########
@@ -680,25 +678,20 @@ class JsonExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper with
output)
}
- test("to_json: verify MapType's value type instead of key type") {
- // Keys in map are treated as strings when converting to JSON. The type
doesn't matter at all.
- val mapType1 = MapType(CalendarIntervalType, IntegerType)
- val schema1 = StructType(StructField("a", mapType1) :: Nil)
- val struct1 = Literal.create(null, schema1)
+ test("from_json - interval support") {
Review comment:
nit: can we follow csv test and test from/to in one test case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
