cloud-fan commented on a change in pull request #27319: [SPARK-30605][SQL] move
defaultNamespace from SupportsNamespace to CatalogPlugin
URL: https://github.com/apache/spark/pull/27319#discussion_r369648949
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala
##########
@@ -93,19 +93,14 @@ class CatalogManager(
}.getOrElse(defaultSessionCatalog)
}
- private def getDefaultNamespace(c: CatalogPlugin) = c match {
- case c: SupportsNamespaces => c.defaultNamespace()
- case _ => Array.empty[String]
Review comment:
This is the place I want to point out. There is no safe default value. If
you don't know the default namespace of a catalog, then you don't know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
