cloud-fan commented on a change in pull request #27318: [SPARK-30603][SQL] Keep
the reserved properties of namespaces and tables private
URL: https://github.com/apache/spark/pull/27318#discussion_r369682197
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsNamespaces.java
##########
@@ -41,34 +39,6 @@
@Experimental
public interface SupportsNamespaces extends CatalogPlugin {
- /**
- * A property to specify the location of the namespace. If the namespace
- * needs to store files, it should be under this location.
- */
- String PROP_LOCATION = "location";
Review comment:
These property names should remain in the public class, as we need the
implementations to read and know them.
The only thing interval is which properties are reserved. We should move the
`RESERVED_PROPERTIES` to `CatalogV2Utils`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
