tgravescs commented on a change in pull request #27313: [SPARK-29148][CORE] Add
stage level scheduling dynamic allocation and scheduler backend changes
URL: https://github.com/apache/spark/pull/27313#discussion_r369827723
##########
File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
##########
@@ -560,9 +672,10 @@ private[spark] class ExecutorAllocationManager(
val stageAttemptId = stageCompleted.stageInfo.attemptNumber()
val stageAttempt = StageAttempt(stageId, stageAttemptId)
allocationManager.synchronized {
- // do NOT remove stageAttempt from stageAttemptToNumRunningTasks,
+ // do NOT remove stageAttempt from stageAttemptToNumRunningTask
Review comment:
No but the comment was wrong there is no stageAttemptToNumRunningTasks
datastructure and didn't want it confusing for people reviewing the change, I
can remove if you like?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
