dbtsai commented on a change in pull request #26929: [SPARK-30289][SQL] DSv2's
partitioning should not accept nested columns
URL: https://github.com/apache/spark/pull/26929#discussion_r369829215
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/V1Table.scala
##########
@@ -78,6 +78,8 @@ private[sql] case class V1Table(v1Table: CatalogTable)
extends Table {
partitions += spec.asTransform
}
+ import
org.apache.spark.sql.connector.catalog.CatalogV2Implicits.TransformHelper
+ partitions.validatePartitionColumns()
Review comment:
Digging the v2 codebase a bit, and I feel currently, we need some work to
actually get v2 sources supporting using nested columns in transform. For
example, in `FileTable`, `override def partitioning: Array[Transform]` is
converted from `PartitionSpec` which doesn't support nested column at all.
Since we are mixing v1 and v2 code here and there, do we have a plan to
untangle them so it will be easier to extend nested column support in v2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
