HyukjinKwon commented on a change in pull request #27324:
[SPARK-30188][SQL][TESTS][FOLLOW-UP] Remove `sorted` in the check of expression
example outputs
URL: https://github.com/apache/spark/pull/27324#discussion_r369895648
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -193,7 +193,7 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
val actual = unindentAndTrim(
hiveResultString(df.queryExecution.executedPlan).mkString("\n"))
val expected = unindentAndTrim(output)
- assert(actual.sorted === expected.sorted)
+ assert(actual === expected)
Review comment:
Yea, I think you can just `git grep -r "assert" . | grep "\.sorted"` and see
if they are all necessary, e.g., remove them and run the tests, see if they
pass. Looks not too many:
```bash
$ git grep -r "assert" . | grep "\.sorted" | wc -l
74
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
