dongjoon-hyun commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-577499721 I think we are safe because we have `spark.sql.analyzer.failAmbiguousSelfJoin`. Do we have a false positive? 1. If this PR makes a correct existing query fail, we can backport this patch with `spark.sql.analyzer.failAmbiguousSelfJoin=false` by default. 2. If this PR prevents only wrong query, we can backport this patch like 3.0. `spark.sql.analyzer.failAmbiguousSelfJoin=true` by default. In both (1) and (2) case, we can claim that the correctness issue is resolved. How do you think about that? (Also, cc @gatorsmile )
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
