dongjoon-hyun commented on a change in pull request #27335:
[SPARK-30601][BUILD][2.4] Add a Google Maven Central as a primary repository
URL: https://github.com/apache/spark/pull/27335#discussion_r369959056
##########
File path: .github/workflows/branch-2.4.yml
##########
@@ -51,14 +51,6 @@ jobs:
export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=512m
-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN"
export MAVEN_CLI_OPTS="--no-transfer-progress"
mkdir -p ~/.m2
- # `Maven Central` is too flaky in terms of downloading artifacts in
`GitHub Action` environment.
- # `Google Maven Central Mirror` is too slow in terms of sycing
upstream. To get the best combination,
- # 1) we set `Google Maven Central` as a mirror of `central` in
`GitHub Action` environment only.
- # 2) we duplicates `Maven Central` in pom.xml with ID
`central_without_mirror`.
- # In other words, in GitHub Action environment, `central` is mirrored
by `Google Maven Central` first.
- # If `Google Maven Central` doesn't provide the artifact due to its
slowness, `central_without_mirror` will be used.
- # Note that we aim to achieve the above while keeping the existing
behavior of non-`GitHub Action` environment unchanged.
- echo
"<settings><mirrors><mirror><id>google-maven-central</id><name>GCS Maven
Central
mirror</name><url>https://maven-central.storage-download.googleapis.com/repos/central/data/</url><mirrorOf>central</mirrorOf></mirror></mirrors></settings>"
> ~/.m2/settings.xml
./build/mvn $MAVEN_CLI_OPTS -DskipTests -Pyarn -Pmesos -Pkubernetes
-Phive -Phive-thriftserver -Pscala-${{ matrix.scala }} -P${{ matrix.hadoop }}
-Phadoop-cloud install
Review comment:
Thank you for making a separate PR. Yes. It will be safer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
