zhengruifeng commented on a change in pull request #27261: [SPARK-30503][ML]
OnlineLDAOptimizer does not handle persistance correctly
URL: https://github.com/apache/spark/pull/27261#discussion_r369987707
##########
File path:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala
##########
@@ -211,11 +211,14 @@ final class EMLDAOptimizer extends LDAOptimizer {
val docTopicDistributions: VertexRDD[TopicCounts] =
graph.aggregateMessages[(Boolean, TopicCounts)](sendMsg, mergeMsg)
.mapValues(_._2)
+ val prevGraph = graph
Review comment:
Thanks! I am on the holidy, so can no reply quickly.
Current change is following what Pregel does,
I will go on looking into it, since the persistance in GraphX is a little
complex.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
