hvanhovell commented on a change in pull request #27267: [SPARK-30556][SQL]
Copy sparkContext.localproperties to child thread
inSubqueryExec.executionContext
URL: https://github.com/apache/spark/pull/27267#discussion_r370107114
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala
##########
@@ -145,9 +145,17 @@ object StaticSQLConf {
"cause longer waiting for other broadcasting. Also, increasing
parallelism may " +
"cause memory problem.")
.intConf
- .checkValue(thres => thres > 0 && thres <= 128, "The threshold must be
in [0,128].")
+ .checkValue(thres => thres > 0 && thres <= 128, "The threshold must be
in (0,128].")
.createWithDefault(128)
+ val SUBQUERY_MAX_THREAD_THRESHOLD =
Review comment:
If its a static conf, then why isn't your unite test failing? Moreover, if
its static then setting it in your test probably does not have any effect
because we use the same JVM/SparkContext to run most tests, the chances are
pretty high that it has been set before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
