ajithme commented on a change in pull request #27267: [SPARK-30556][SQL] Copy
sparkContext.localproperties to child thread inSubqueryExec.executionContext
URL: https://github.com/apache/spark/pull/27267#discussion_r370193245
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala
##########
@@ -145,9 +145,17 @@ object StaticSQLConf {
"cause longer waiting for other broadcasting. Also, increasing
parallelism may " +
"cause memory problem.")
.intConf
- .checkValue(thres => thres > 0 && thres <= 128, "The threshold must be
in [0,128].")
+ .checkValue(thres => thres > 0 && thres <= 128, "The threshold must be
in (0,128].")
.createWithDefault(128)
+ val SUBQUERY_MAX_THREAD_THRESHOLD =
Review comment:
i see. as per documentation in
https://github.com/apache/spark/blob/705fc6ad9328c1092299b83071b6ec3b1d6f9c4d/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala#L26
its should not modified. I followed the same way `BroadcastExchangeExec`
creates executionContext. My initial guess is executionContext is not created
till first subquery hence it work for UT. i will further investigate and get
back with analysis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
