vanzin commented on a change in pull request #27208: [SPARK-30481][CORE]
Integrate event log compactor into Spark History Server
URL: https://github.com/apache/spark/pull/27208#discussion_r370234929
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -1175,6 +1237,21 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
}
deleted
}
+
+ /** NOTE: 'task' should ensure it executes 'endProcessing' at the end */
Review comment:
Hmm, perhaps this method could take care of calling `endProcessing` too
(e.g. by wrapping the task)? Should be just a small adjustment at the call site.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
