ayudovin commented on issue #27034: [SPARK-30122][K8S] Allow setting serviceAccountName for executor pods URL: https://github.com/apache/spark/pull/27034#issuecomment-577879919 > Hi, @ayudovin . > > 1. In general, new feature should not create a breaking change. For example, this PR enforce service account configuration additionally. If executor service account is not given, we had better fallback to use driver service account. > 2. Do you think we can have a test case for this? Test case is important to protect your contribution from the future changes. Unfortunately, I can not find a way to add a unit test for it. Maybe, you can give advice or tell where I can find an example of tests for these properties.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
