Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/2504#issuecomment-75100303
@sryza is the idea here to maintain backward compatibility by re-using the
ShuffleWriteMetrics class for spill metrics?
I preferred the old approach, where you defined a DiskWriteMetrics class,
and then ShuffleReadMetrics includes "val spillMetrics = new DiskWriteMetrics",
and shuffle write metrics includes two DiskWriteMetrics (one for spill and one
for normal write). To make everything backward compatible, I might just write
the JsonMetrics in the same way as before for ShuffleWriteMetrics. I'm just
concerned this approach is pretty hard to understand for a new person looking
at this. Happy for others to weigh in though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
