SaurabhChawla100 commented on a change in pull request #27292:
[SPARK-30582][WEBUI] Spark UI is not showing Aggregated Metrics by Executor in
stage page
URL: https://github.com/apache/spark/pull/27292#discussion_r370449085
##########
File path: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
##########
@@ -473,27 +492,6 @@ $(document).ready(function () {
var accumulatorTable =
responseBody.accumulatorUpdates.filter(accumUpdate =>
!(accumUpdate.name).toString().includes("internal."));
- // rendering the UI page
- var data = {"executors": response};
Review comment:
Before Fix- In existing code
`var data = {"executors": response};
$.get(createTemplateURI(appId, "stagespage"), function(template)
{
tasksSummary.append(Mustache.render($(template).filter("#stages-summary-template").html(),
data));`
In code response object comes from this api call ("$.getJSON(endPoint + "/"
+ stageAttemptId, function(response, status, jqXHR)") and this API call is
invoked before the call made to get the html page of stage and then adding that
response in the html page.
After Fix
The stage page html is first loaded and all the api calls are inside the
`$.get(createTemplateURI(appId, "stagespage"), function(template) {` , So we
dont need to add the response here in this scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
