WeiWenda commented on a change in pull request #27349: [SPARK-30617][SQL] Stop
check values of spark.sql.catalogImplementation to improve expansibility
URL: https://github.com/apache/spark/pull/27349#discussion_r370569479
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala
##########
@@ -36,9 +36,13 @@ object StaticSQLConf {
.createWithDefault(Utils.resolveURI("spark-warehouse").toString)
val CATALOG_IMPLEMENTATION =
buildStaticConf("spark.sql.catalogImplementation")
+ .doc("Spark built-in implementation is in-memory and hive," +
+ "when set to yourImpl(can be any words), " +
+ "you need also provide following configuration to make everything going"
+
+ "spark.sql.catalogImplementation.yourImpl.builder" +
+ "spark.sql.catalogImplementation.yourImpl.externalCatalog")
.internal()
Review comment:
I find that internal didn't effect anything. So I have removed .internal()
in latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]