MaxGekk commented on issue #27351: Revert "[SPARK-25496][SQL] Deprecate from_utc_timestamp and to_utc_timestamp" URL: https://github.com/apache/spark/pull/27351#issuecomment-578249152 @gatorsmile I do understand importance of backward compatibility but: - Deprecated functions break semantic of the timestamp type. Its values are micros since the epoch which is in UTC timezone. Placing values of another meaning spreads errors across user apps unpredictably. - You mentioned Hive/Impala. but if we looked at common used time API like Java 8 time API, Joda and etc. The libraries don't provide such functions. - isn't the major version Spark 3.0 is good time to remove ugly functions from API? If you think we should put more details to Spark docs, let's do that. - How else can we inform users that some functions have been deprecated already if we don't throw an exception, and force users to set SQL config, explicitly. At the moment, we don't have any mechanisms of informing users about deprecated functions, unfortunately. As summary, I cannot agree with reverting the changes. I would update docs and place a link to the docs into the exception message, and update expression description as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
