ishikin commented on a change in pull request #27311: [SPARK-27996][WEBUI] Send
HTTP redirect using the correct protocol when Spark History server is deployed
behind the reverse proxy
URL: https://github.com/apache/spark/pull/27311#discussion_r370833812
##########
File path:
core/src/test/scala/org/apache/spark/deploy/history/ApplicationCacheSuite.scala
##########
@@ -370,7 +370,9 @@ class ApplicationCacheSuite extends SparkFunSuite with
Logging with MockitoSugar
val request = mock[HttpServletRequest]
when(request.getMethod()).thenReturn("GET")
-
when(request.getRequestURI()).thenReturn("http://localhost:18080/history/local-123/jobs/job/";)
+ when(request.getRequestURI()).thenReturn("/history/local-123/jobs/job/")
Review comment:
getRequestURI() was incorrectly mocked here. getRequestURI() does not return
protocol or host name, only part of the path after and until the query
parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
