Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4514#discussion_r25024948
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -21,9 +21,36 @@ package org.apache.spark.util
* An interface to represent clocks, so that they can be mocked out in
unit tests.
*/
private[spark] trait Clock {
- def getTime(): Long
+ def getTimeMillis(): Long
+ def waitTillTime(targetTime: Long): Long
}
-private[spark] object SystemClock extends Clock {
- def getTime(): Long = System.currentTimeMillis()
+private[spark] class SystemClock extends Clock {
+
+ val minPollTime = 25L
+
+ def getTimeMillis(): Long = System.currentTimeMillis()
+
+ def waitTillTime(targetTime: Long): Long = {
--- End diff --
I find this is used in `org.apache.spark.streaming.util.RecurringTimer`
which is still needed in `JobGenerator` and `BlockGenerator`. I can make the
other change though, one sec...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
