zhengruifeng commented on a change in pull request #27360:
[SPARK-30642][ML][PYSPARK] LinearSVC blockify input vectors
URL: https://github.com/apache/spark/pull/27360#discussion_r370934439
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala
##########
@@ -220,8 +227,22 @@ class LinearSVC @Since("2.2.0") (
None
}
- val getAggregatorFunc = new HingeAggregator(bcFeaturesStd,
$(fitIntercept))(_)
- val costFun = new RDDLossFunction(instances, getAggregatorFunc,
regularization,
+ val standardized = instances.map {
Review comment:
Move the standardization outside of `HingeAggregator`, so that no longer
need to standardize input in each iter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
