zero323 commented on a change in pull request #27363:
[SPARK-29777][FOLLOW-UP][SPARKR] Remove no longer valid test for recursive calls
URL: https://github.com/apache/spark/pull/27363#discussion_r370972156
##########
File path: R/pkg/tests/fulltests/test_utils.R
##########
@@ -101,7 +104,10 @@ test_that("cleanClosure on R functions", {
# nolint end
expect_true("g" %in% ls(env))
expect_true("l" %in% ls(env))
- expect_true("f" %in% ls(env))
+ # Enable once SPARK-30629 is fixed
+ # nolint start
+ # expect_true("f" %in% ls(env))
Review comment:
They do, that's why it is wrapped with `nolint`. If I didn't mess up
anything, this is cherry picked from previous version of SPARK-23435 proposal,
and already passed all tests, but let's see how it goes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
