mridulm commented on a change in pull request #26682: [SPARK-29306][CORE] Stage
Level Sched: Executors need to track what ResourceProfile they are created with
URL: https://github.com/apache/spark/pull/26682#discussion_r370980147
##########
File path:
core/src/main/scala/org/apache/spark/resource/ExecutorResourceRequests.scala
##########
@@ -32,9 +34,9 @@ import org.apache.spark.resource.ResourceProfile._
*/
private[spark] class ExecutorResourceRequests() extends Serializable {
- private val _executorResources = new mutable.HashMap[String,
ExecutorResourceRequest]()
+ private val _executorResources = new ConcurrentHashMap[String,
ExecutorResourceRequest]()
Review comment:
This change to ConcurrentHashMap - is it a correctness fix ? Or does use of
ExecutorResourceRequests become multi-threaded now and was not earlier ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
