Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-75157364
FWIW I think:
- needs a rebase
- scaladoc should be consistent with others in `RDD.scala` -- no shell
example
- `JavaRDD` needs this even more since I think you have to call
`javaRDD.rdd().partitions().length` right now
- Shouldn't it be `partitions.length` since it's an array? `size` works but
requires an implicit conversion I think. While we're bothering, might as well
do the direct efficient thing
The one bummer here is that there are 20-30 usages of `partitions.size` in
the code already. It's not hard to make those use the method. The usual worry
about annoying merge conflicts rears its head though. Still it feels worth
doing right if at all?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
